Open chrisjsewell opened 3 years ago
Actually this error on yaml should be harmless I think, it keeps going with the python version it found (but yes, it might still be better with setuptools).
Checking quickly in the logs of the linked build, I see that messages make: Warning: File '/tmp/bigdft-suite/futile/Makefile.in' has modification time 5.3 s in the future configure: error: newly created file is older than distributed files!
This seems to be the failing point ... It looks like there is some time discrepancy in the clocks of the guest vm and the host ? so make is confused and does not know which files to build or not... And I guess that at the second attempt, it's more than 5s later when it reaches this point, so it's fine this time ?
I found some sources saying that virtualbox is subject to drifts, for example when the host is suspended for a while, the guest time is out of sync. It looks like virtualbox resynchronizes the time every 20 minutes by default, but this setting can be changed to something like 10 seconds, there are some options here for vagrant as well https://stackoverflow.com/questions/19490652/how-to-sync-time-on-host-wake-up-within-virtualbox
I'll see if I can reproduce this behaviour elsewhere
Thanks for the analysis, I guess as at least a temporary fix we can add a retry to the make task
I published v1.3.5 with a retry attempt if the build fails.
Thanks but... I'm going to be a bit of a stickler here and ask can you please adhere to the formal PR and review process for making these changes 😬
Indeed, I'll try to do it properly from now on. Thanks for the other changes.
I didn't notice this before but the compilation is failing, both locally and in the CI (https://github.com/marvel-nccr/quantum-mobile/runs/1287141082?check_suite_focus=true). But weirdly it passes on the second pass.
It looks possibly to do with:
/usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'python_requires'
which I believe is due to the version of setuptools being too old (but somehow being ok on the second pass!?). So I will try making a PR to ensure that the setuptools version is up-to-date.On a related note, the whole bespoke build/installation of pyyaml all feels a bit unnecessary TBH, it would be nice if you could just replace it with
pip install pyyaml~=5.1.2