search

marvel-nccr / ansible-role-bigdft

Other
0 stars 1 forks source link

🔧 Standardise CI #9

Closed chrisjsewell closed 3 years ago

chrisjsewell commented 3 years ago

See https://github.com/marvel-nccr/quantum-mobile/issues/132

chrisjsewell commented 3 years ago

@adegomme as mentioned above, I'm moving all the role repos to a "standardised structure". This includes moving to GH Actions and using different base docker images for the testing. As you can see in the checks, this is failing for Ubuntu 1804 😢 (also for 2004, but that doesn't need to be addressed right now) Can you have a look and see if there is any obvious fix?

(note, it might just be that the image lacks some packages, I'm making a PR like this for all codes, so we shall see if they also have this issue)

adegomme commented 3 years ago

I'm trying to reproduce locally, as molecule seems to cut the output we see before the failure (it squashes everything into one line, which has limits on linux, and then seems to remove all further stderr output)... I had some failures as I had ansible-galaxy setup with an old version of the role and couldn't find out why it was using an old bigdft for a while ... Now I'm looking at how to get the complete log.

adegomme commented 3 years ago

with --debug I was able to see that it's complaining about not finding wget (or curl). I'm trying to add wget (and bzip2 as we use a tar.bz at this step) to the installed packages requirements to see if it's enough (they are already on quantum-mobile, so that was not apparent before ).

chrisjsewell commented 3 years ago

thanks, yeh for reference, this is the old docker build:

https://github.com/marvel-nccr/ubuntu-docker-base/blob/master/Dockerfile

and this is the new one and what is derived from

https://github.com/marvel-nccr/docker-ubuntu1804-ansible/blob/master/Dockerfile https://github.com/geerlingguy/docker-ubuntu1804-ansible/blob/master/Dockerfile

bit of a pain to change, but hopefully better in the long run

adegomme commented 3 years ago

I just passed it locally, so let's see.

adegomme commented 3 years ago

20.04 still fails, apparently because of libblacs-mpi-dev, which is no longer installable, but provided by libscalapack-mpi-dev. Fixing this as well.

chrisjsewell commented 3 years ago

20.04 still fails, apparently because of libblacs-mpi-dev, which is no longer installable, but provided by libscalapack-mpi-dev. Fixing this as well.

I'd maybe not do this now and just remove the ubuntu2004

chrisjsewell commented 3 years ago

Its not necessary to support 20.04 just yet, although obviously is it is easy to support then we should. If that requires extra packages to install then maybe not worth it yet? or make the install only run if on 20.04

chrisjsewell commented 3 years ago

hmm, are we encountering the hanging install issue?

adegomme commented 3 years ago

hmm, are we encountering the hanging install issue?

no, it takes a while to build, but no hanging with this version (I tried this weekend on a fork btw : https://github.com/adegomme/quantum-mobile/actions/runs/312812103 )

adegomme commented 3 years ago

Its not necessary to support 20.04 just yet, although obviously is it is easy to support then we should. If that requires extra packages to install then maybe not worth it yet? or make the install only run if on 20.04

Well it's actually a package to remove. I need to check if 16.04 still passes without it, though. 20.04 complained it was missing a C++ compiler, btw, I had to add g++ as a dependency, it's building now. Maybe it's missing from the docker ?

chrisjsewell commented 3 years ago

I'm going to remove ubuntu2004 for now and we sort that in a seperate PR if thats ok?

adegomme commented 3 years ago

no, it works :p just waiting for 16.04 to completely finish building, but it seems to be heading to a success.