search

marvel-nccr / ansible-role-siesta

Ansible role for installing the siesta code
Other
0 stars 3 forks source link

Pull request for support of new version of Siesta almost ready #11

Closed albgar closed 3 years ago

albgar commented 3 years ago

In my fork (albgar/ansible-role-siesta) I have prepared a new version of the Siesta role that installs the MaX-1.1 version. The latest commit in master passes the CI checks for ubuntu18, but not for ubuntu16 (since this version does not have a fully featured libxc apt package). I just need a bit of help with the proper ansible way to deactivate libxc support (which is optional in Siesta) for ubuntu16. The relevant variable in defaults/main.yml is libgridxc_libxc_incantation, which should be empty for ubuntu16. Also, in tasks/main.yml, in the apt section, libxc-dev should be removed for ubuntu16.

ltalirz commented 3 years ago

@albgar the ubuntu version is available via the ansible_distribution_version, see e.g. here

You are welcome to fix the role for 16.04, but I'd probably be even more interested in adding support for 20.04 (support for 16.04 will end in April 2021 and we switched to 18.04 for Quantum Mobile a long time ago). In order to add tests on 20.04, simply add it here: https://github.com/marvel-nccr/ansible-role-siesta/blob/master/.github/workflows/ci.yml#L30