marvel-nccr / quantum-mobile

A Virtual Machine for computational materials science
https://quantum-mobile.readthedocs.io
Other
91 stars 32 forks source link

AiiDAlab-related things to be fixed before the next release. #174

Closed yakutovicha closed 3 years ago

yakutovicha commented 3 years ago

There a few AiiDAlab-related things that I consider important before making a new release of QuantumMobile:

yakutovicha commented 3 years ago

Concerning the OPTIMADE client point. This is what I see in the QuantumMobile:

image (3)

And this is how it should look like:

Screenshot 2021-03-25 at 23 32 21

The issue is related to the appearance of GridspecLayout from ipywidgets. The OptimadeQueryProviderWidget widget, which is derived from GridspecLayout, is not displayed.

chrisjsewell commented 3 years ago

Just to note here, after discussion with @yakutovicha, I have already found a potential way forward for the layout issue fix, in that I've noted in the debug console that ipywidgets does not seem to be able to find the requirejs package (a common Javascript package used for importing other packages). I'll have a look and see why it isn't being installed into jupyter's Javascript environment

chrisjsewell commented 3 years ago

Fix the appearance of the OPTIMADE client: the provider dropdown list isn't shown.

The issue here was that ipywidgets-extended was not installed.

I have not seen this listed in any of the app requirements, and the same with ipytree (is this actually used somewhere?)

I'm adding ipywidgets-extended to the aiidalab-qe jupyter requirements for now

(cc also @csadorf)

csadorf commented 3 years ago

have not seen this listed in any of the app requirements, and the same with ipytree (is this actually used somewhere?)

I'm adding ipywidgets-extended to the aiidalab-qe jupyter requirements for now

(cc also @csadorf)

The ipywidgets-extended package is a dependency of optimade-client, which is a dependency of aiidalab-widgets-base which is a dependency of the QE app. The ipywidgets-extended dependency is therefore only an indirect dependency of the QE app.

The ipytreepackage is a dependency of the aiidalab-widgets-base develop branch, but we apparently forgot to add it to the requirements. That would need to be fixed prior to the next release, so I'm proposing to add it in https://github.com/aiidalab/aiidalab-widgets-base/pull/195 .

chrisjsewell commented 3 years ago

thanks

The ipywidgets-extended dependency is therefore only an indirect dependency of the QE app.

but if this is not installed into the jupyter environment, then the QE app is effectively broken, so surely it has to be added in the requirements of least one of the base or qe app, or QM will never know to install it

chrisjsewell commented 3 years ago

Note currently optimade-client is installed into the aiida environment, but not the jupyter one, which is why ipywidgets-extended is missing