search

marvelapp / devices.css

Pure CSS phones and tablets
MIT License
3.95k stars 611 forks source link

Added MacBook Pro device #12

Closed iKlaus closed 9 years ago

iKlaus commented 10 years ago

Hey there,

you created an awesome collection of beautiful device. Well done. I had a need for exactly what you created and a little more. In addition to the mobile devices I needed a representation of a desktop device, therefore I created a MacBook Pro (ish) style in the sense of this library. In contrast to the existing devices the MacBook doesn't respect the screen dimensions of the original, for an obvious reason: you cannot display a pixel-perfect MacBook on a MacBook. Nonetheless, it may be of use for someone out there.

Cheers Klaus

marcj commented 10 years ago

+1

marcj commented 10 years ago

@marvelapp would be cool if you could merge it ASAP, I need it in several projects.

morz82 commented 10 years ago

@iKlaus this is awesome, great work!

marcj commented 9 years ago

@ping @ping @ping @ping @ping @ping @ping

oh-moore commented 9 years ago

Hey guys, we'll get this sorted over the weekend. Very useful frame

morz82 commented 9 years ago

@marcj + @iKlaus apologies for the delay, we'll get this sorted asap, thank you so much for contributing

timmyg commented 9 years ago

can this be merged? Is there somewhere that has the html for this? Thanks!

jalcine commented 9 years ago

@timmyg commented on Aug 25, 2015, 5:51 PM EDT:

can this be merged? Is there somewhere that has the html for this? Thanks!

The HTML for this is in the diff.

jalcine commented 9 years ago

@iKlaus Could you rebase with less of the white space changes you've made? Using git commit --interactive can help. If not, I can send you a PR (or send one here with those fixtures).

iKlaus commented 9 years ago

@jalcine here you go

jalcine commented 9 years ago

@iKlaus commented on Sep 6, 2015, 4:46 PM EDT:

@jalcine here you go

Awesome, that should be a less instructive commit for @marvelapp to consider merging. Thanks for doing that!

olegtsaplin commented 9 years ago

Thanks @iKlaus! I merged this in along with a few tweaks to make it look a bit more like the new Retina Macbook Pro

iKlaus commented 9 years ago

You are welcome. Glad you like it and finally merged it :) Thanks for your tweaks. Looks really neat :+1: