search

marvelapp / devices.css

Pure CSS phones and tablets
MIT License
3.95k stars 611 forks source link

worked on issue #2 and #4 #7

Closed EloquentZebra closed 7 years ago

EloquentZebra commented 10 years ago

hopefully did it right ;)

4 #2

willscripted commented 10 years ago

@faitnoise I think you are on the right track :smile:

It would be beneficial to scope the device CSS in a way so nothing leaks into the page

You might go a step further and make the .device class something more specific. Maybe .marvel-device. The reason being, some applications that find this useful will already have a .device class defined. Those applications probably wont have a .marvel-device class defined, so the chance of style leakage/collision is much lower.

As for issue 2, oisinlavery is essentially asking for a search-and-replace for all the #id selectors. Because ids can be a world of hurt for stylesheet maintainers.

Something like

  #iphone5s   => .iphone5s
  #iphone5c   => .iphone5c
  #iphone4s   => .iphone4s
  #nexus5     => .nexus5
  #ipad       => .ipad
  #lumia920   => .lumia920
  ... etc ...
EloquentZebra commented 10 years ago

Hmm, nice input.

I'll see what I can do about it.

Depends on how much I have to do at work 😄

I guess I'll update this request soon. Am 09.08.2014 15:38 schrieb "will-ob" notifications@github.com:

@faitnoise https://github.com/faitnoise I think you are on the right track [image: :smile:]

It would be beneficial to scope the device CSS in a way so nothing leaks into the page

You might go a step further and make the .device class something more specific. Maybe .marvel-device. The reason being, some applications that find this useful will already have a .device class defined. Those applications probably wont have a .marvel-device class defined, so the chance of style leakage/collision is much lower

As for issue 2, oisinlavery is essentially asking for a search-and-replace for all the #id selectors. Because ids can be a world of hurt for stylesheet maintainers.

Something like

iphone5s => .iphone5s

iphone5c => .iphone5c

iphone4s => .iphone4s

nexus5 => .nexus5

ipad => .ipad

lumia920 => .lumia920

... etc ...

— Reply to this email directly or view it on GitHub https://github.com/marvelapp/devices.css/pull/7#issuecomment-51686833.