marvelapp / react-ab-test

A/B testing React components and debug tools. Isomorphic with a simple, universal interface. Well documented and lightweight. Tested in popular browsers and Node.js. Includes helpers for Mixpanel and Segment.com.
MIT License
240 stars 47 forks source link

userIdentifier causes infinite render loop #24

Closed pr0da closed 3 years ago

pr0da commented 3 years ago

Table of Contents

Expected Behavior

The userIdentifier prop should not cause infinite render loop, when used on the client side.

Current Behavior

When the userIdentifier prop is present, it causes infinite render loop.

Possible Solution

Steps to Reproduce (for bugs)

https://codesandbox.io/s/white-firefly-o3bqr

Trigger a re-render with the button.

Context

Your Environment

j-5-s commented 3 years ago

im also seeing this issue. I made a pr that should address it.

moretti commented 3 years ago

This should be fixed in v3.0.1.

AlexanderChiclana commented 1 year ago

This should be fixed in v3.0.1.

Still having this issue, happens when trying to switch between variants locally if there is any userIdentifier set.

Tried with 3.0.1 and 3.1.0