search

marvhus / jacr

a Jai Cryptography tool
GNU General Public License v3.0
1 stars 0 forks source link

Better errors #1

Closed marvhus closed 1 year ago

marvhus commented 1 year ago

Currently jacr just asserts when there is invalid input to the ciphers. (e.g. no key, and key is not a number).

Making it print what the error is and then exiting is a bit more understandable than just immediately crashing for a user who doesn't work on developing jacr.

Preferably there should be no assertions except for when something horribly wrong has happened that probably isn't the users fault, and rather the developer, or just random chance.

I'm not 100% sure how I am going to implement this, but it is something I plan on doing.

marvhus commented 1 year ago

Fixed in: https://github.com/marvhus/jacr/commit/d442302ea1b7b882e2473584746bb56cbcfe6934
Though as noted in the commit message, even when returning with non 0 exit code, it will continue running stuff that is piped. Not sure if there is a solution to this, but we'll have to try.