marvin-zhao / ipaddr-py

Automatically exported from code.google.com/p/ipaddr-py
0 stars 0 forks source link

IPXNetwork should provide an iterator for its subnets #43

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. >>> import ipaddr
2. >>> net = ipaddr.IPv6Network('1234:1234:1234::/48')
3. >>> net.subnet(16)

Please provide any additional information below.

For very high number of subnets this could be unacceptable for its high
memory usage or if you need to assign subnets in a counter-like manner.

i posted[1] a patch to Rietveld (but really i don't know how does it works)
with relative tests.

[1] http://codereview.appspot.com/132049

Original issue reported on code.google.com by marco.gi...@gmail.com on 17 Oct 2009 at 10:06

GoogleCodeExporter commented 9 years ago
hey marco,

thanks for sending the patch! before I dig into this, I wanted to check to see 
if
you'd 'signed' the contributor license agreement.  Same goes for the other patch
you've sent in.

one of these days, I'll get around to finding out where the list of
already-signed-cla lives so I don't have to ask.

cheers,
/peter

Original comment by pmo...@google.com on 20 Oct 2009 at 5:30

GoogleCodeExporter commented 9 years ago
Now i did, i only hope that all my havings do not became google's havings or 
google's
lawyers will not knock at my door.

Please, consider to rename the function in something more coherent like 
'itersubnets'.

Original comment by marco.gi...@gmail.com on 20 Oct 2009 at 9:29

GoogleCodeExporter commented 9 years ago
fixed in r124

Original comment by pmo...@google.com on 2 Nov 2009 at 7:26