Closed ioBrokerChecker closed 3 years ago
[x] Please at least use ioBroker Translator to provided more languages than German and English, e.g. https://github.com/marvingrieger/ioBroker.haassohn/blob/c3dfc6c00485e27594ad94de982e6d9826221990/io-package.json#L69
[x] The referenced docs are non-existing, better specify your readme https://github.com/marvingrieger/ioBroker.haassohn/blob/c3dfc6c00485e27594ad94de982e6d9826221990/io-package.json#L75
[x] The docs are only templates, please at least add them to .npmignore otherwise they will be downloaded at every installation w/o providing any relevant content
[x] I would recommend you to migrate testing from travis/appveyor to GH actions, which is a lot faster and of course integrated
[x] adapter startup unit test is now deprecated, so you can remove https://github.com/marvingrieger/ioBroker.haassohn/blob/master/test/unit.js and https://github.com/marvingrieger/ioBroker.haassohn/blob/c3dfc6c00485e27594ad94de982e6d9826221990/package.json#L42 except you will define your own unit tests in the near future
[x] You should really avoid using var
like https://github.com/marvingrieger/ioBroker.haassohn/blob/c3dfc6c00485e27594ad94de982e6d9826221990/main.js#L16 and everywhere else in your code. Modern javascript has const
and let
, for such patterns I can really recommend you the eslint
module which takes care of this
[x] module.parent
is deprecated https://github.com/marvingrieger/ioBroker.haassohn/blob/c3dfc6c00485e27594ad94de982e6d9826221990/main.js#L487, better check module === require.main
[x] you have a very complex adapter disabling handling in your code, you can simply call adapter.terminate
this will stop the execution without disabling the adapter, which is pretty much what you do in your code
Adapter is now added
We saw your adapter and if it is ready please request that it is added to the repository. With this it becomes available for all users. Please consult https://github.com/ioBroker/ioBroker.repositories#add-a-new-adapter-to-the-latest-repository and the following sections for more details. If you need help, contact us in the forum https://forum.iobroker.net/ or in the developer chat https://github.com/iobroker-community-adapters/info .
Thank you for your support.