search

marvingrieger / ioBroker.haassohn

This is an adapter for ioBroker that enables to control Haas+Sohn devices.
MIT License
8 stars 7 forks source link

ECO Mode, adapter restarts in case of failures #60

Closed shaarkys closed 8 months ago

shaarkys commented 8 months ago

Hi, based on https://github.com/marvingrieger/ioBroker.haassohn/issues/58, I tried to make some modifications (not a developer, with help of ChatGPT), it's working for me - feel free to cherry pick or reject eventually ;-)

marvingrieger commented 8 months ago

The test breaks since the "news" part within io-package.json has too many entries (some of the oldest ones need to be removed).

In terms of the writable state: if eco_editable true indicates that then and only then, the oven supports setting eco mode, the state should only be writable if this attribute exists. In other words: We need a plausibility that checks whether this is the case and if so, enables to send the command to the oven.

Otherwise, we probably send unsupported commands to the oven.

shaarkys commented 8 months ago

Interesting, it do not report any issue to me.

Correct, that's my assumption as well - however the modification is rather for inspiration, I never ever developed IOBroker adapter :-)

Checking that condition prior setting it, might be wise :-) I can try with ChatGPT later but can't sign off the results (not developer)

Also I will probably revert the restarts as it didn't bring expected results (my HaasSohn WLAN module is disconnecting several times a day but after I switched to Mikrotik and sometimes it do not recover :-( )

shaarkys commented 8 months ago

Closing, will try to resubmit new one