search

marvinkreis / rofi-file-browser-extended

Use rofi to quickly open files
MIT License
240 stars 15 forks source link

Feature request: Show cover files instead of folder icon for music folders/files #11

Open RaitaroH opened 5 years ago

RaitaroH commented 5 years ago

So the idea is if a folder has a cover.jpg in it or something like that use that image as an icon instead.

The other option (still pretty cool) is to do the same using embedded covers made with youtube-dl for example. ydl is using ffmpeg as far as I know so it needs some file processing but that would be very cool in my opinion.

marvinkreis commented 5 years ago

Interesting idea. If converting jpgs into the right format is fast enough, this might easy to implement as well. I think using embedded images is a bit overkill though, I think this would require caching to be fast enough.

DaveDavenport commented 4 years ago

I wonder why this does not use rofis build in icon_fetcher.. It is async (uses the threadpool rofi has internally) and you can just pass it a image uri and it will create an icon.

It would make adding this option easy enough. (and async!)