search

marvinkreis / rofi-file-browser-extended

Use rofi to quickly open files
MIT License
242 stars 15 forks source link

make fails on file_browser due to libnkutils static library issue #4

Closed jpwgarrison closed 6 years ago

jpwgarrison commented 6 years ago

On ubuntu 18.04 I am seeing the following error:

*** Warning: Linking the shared library file_browser.la against the
*** static library ../submodules/libnkutils/libnkutils.a is not portable!
/usr/bin/x86_64-linux-gnu-ld: ../submodules/libnkutils/libnkutils.a(___submodules_libnkutils_libnkutils_a-xdg-theme.o): relocation R_X86_64_PC32 against symbol `nk_xdg_theme_get_icon' can not be used when making a shared object; recompile with -fPIC
/usr/bin/x86_64-linux-gnu-ld: final link failed: Bad value
collect2: error: ld returned 1 exit status
Makefile:1153: recipe for target 'file_browser.la' failed
make[1]: *** [file_browser.la] Error 1
make[1]: Leaving directory '/home/jon/repos/personal/rofi-plugins/rofi-file_browser-extended'
Makefile:1008: recipe for target 'all' failed
jpwgarrison commented 6 years ago

sorted, via an IRC angel. /rofi-file_browser-extended/Makefile.am does not need the -nolibtool test.

jpwgarrison commented 6 years ago

Turns out it does need the test, just a little edit, as @marvinkreis pointed out.

Line 7 in /rofi-file_browser-extended/Makefile.am should be:

include $(top_srcdir)/../submodules/libnkutils/libnkutils.mk