search

marvinkreis / rofi-file-browser-extended

Use rofi to quickly open files
MIT License
240 stars 15 forks source link

Fix building with GCC 14 on i686 #54

Open listout opened 3 months ago

listout commented 3 months ago

GCC 14 (and above) have enabled certain compiler flags such as Wincompatible-pointer-types that causes build time errors such as

rofi-file-browser-extended-1.3.1/src/icons.c:52:57: error: passing argument 2 of ‘g_array_steal’ from incompatible pointer type [-Wincompatible-pointer-types] 52 char** icon_names_raw = g_array_steal ( icon_names, &num_icon_names ); ^~~~~~~
long unsigned int *

In file included from /usr/include/glib-2.0/glib.h:33, from /usr/include/glib-2.0/gmodule.h:30, from /var/tmp/portage/x11-misc/rofi-file-browser-extended-1.3.1-r1/work/rofi-file-browser-extended-1.3.1/src/icons.c:1: /usr/include/glib-2.0/glib/garray.h:86:54: note: expected ‘gsize ’ {aka ‘unsigned int ’} but argument is of type ‘long unsigned int ’ 86 | gsize len); | ~~~~^

My patch attempts to fix this error and some other C99 related warnings. First reported on Gentoo linux, please reffer https://bugs.gentoo.org/928491 for more details