search

marvinkreis / rofi-file-browser-extended

Use rofi to quickly open files
MIT License
240 stars 15 forks source link

Segmentation fault on file_browser #6

Closed Georacer closed 5 years ago

Georacer commented 5 years ago

Hello,

I am in Ubuntu 18.04.1 LTS, with rofi 1.5.0, installed from apt.

I have installed the plugins manually, and used libtool to place it in the /usr/lib/x86_64-linux-gnu/rofi/.

I launch file_browser with rofi -show file_browser -show-icons I get

Mode file_browser is not enabled. I have enabled it for now.
Please consider adding file_browser to the list of enabled modi: modi: window,run,ssh,file_browser.

So far so good.

But then, when I navigate in ~/Desktop, it crashes with

Segmentation fault (core dumped)

Tell me if I can provide with more information.

P.S. I don't seem to understand the :cmd syntax to open a directory or file. Can you provide an example?

Thanks in advance

marvinkreis commented 5 years ago

Hi,

I looked into it, and there was a bug, that made fallback icon themes result in segmentation faults, which might cause this. I pushed a fix for the bug. Can you check if it works with the new version?

I explained the :<cmd> syntax pretty poorly in the README. An example will probably explain it better: Entering :gimp will open the next selected file with gimp, or entering :mv "%s" "newname" will rename the next selected file.

Oh, and thanks for the bug report.

Georacer commented 5 years ago

I have pulled master, recompiled and re-installed. I confirm that I can navigate without core dumps (so far). Thanks for that!

Regarding :<cmd>: I couldn't understand its usage because entering :<cmd in the prompt didn't have any kind of effect. Only after I accidentally hit enter again on the file and it opened with <cmd> did I realize what was going on.

I suggest (if you feel like it and agree): EITHER: emphasize in documentation that :<cmd> is a state change/ augmenting command and doesn't have an immediate effect. OR: If you don't want :<cmd> to affect all future file opens, have the selected file immediately open with <cmd> upon hitting :<cmd>.

Thanks for your work!

marvinkreis commented 5 years ago

I agree that the :<cmd> stuff is a bit weird. I think I could change it so the user can select a file with Shift+Enter and is then prompted with which program to open the file.

Georacer commented 5 years ago

The new :cmd interface works fine. I have set nautilus the default in the launching command and Shift+Enter for custom programs works fine.