search

marvinkreis / rofi-file-browser-extended

Use rofi to quickly open files
MIT License
240 stars 15 forks source link

Feature request: Separate hidden file shortkeys #7

Closed Georacer closed 5 years ago

Georacer commented 5 years ago

I'd like to add file_browser plugin to the rest of the modi of my regular rofi launch command. But as soon as I get to this modi, it captures shift+left/right to show/hide hidden files and can't navigate to other modi anymore.

Could a separate shortkey for hidden files be added (e.g. shift+up/down)?

marvinkreis commented 5 years ago

Hi, thanks for the suggestion.

Unfortunately I can only use keybindings defined by rofi (which is why I was using the mode-switch keybindings). I'll change it to Alt+1, which is one of the keybindings that rofi defines for custom actions.

EDIT: Nevermind, Alt+1 is also used for mode-switching, although rofi -show keys says it's for custom actions. I could change it to Alt+0 and hope no one will use it with 10 active modes. Any other ideas?

marvinkreis commented 5 years ago

Some other options:

  1. Use Ctrl+Enter to toggle hidden files, but this only works the input field is empty
  2. Use Shift+Right to enable hidden files, but switch to the next mode if hidden files are already enabled (and the other way around for Shift+Left)

I think the most sensible way is to implement both, use (1) as default, and add a command line option to use (2).

Georacer commented 5 years ago

Sounds great!

I'm not sure if you have implemented this already, but a cmd option to enable hidden files would complement this nicely, I think.

On Thu, 27 Sep 2018, 05:15 Marvin Kreis, notifications@github.com wrote:

Some other options:

  1. Use Ctrl+Enter to toggle hidden files, but this only works the input field is empty
  2. Use Shift+Right to enable hidden files, but switch to the next mode if hidden files are already enabled (and the other way around for Shift+Left)

I think the most sensible way is to implement both, use (1) as default, and add a command line option to use (2).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/marvinkreis/rofi-plugins/issues/7#issuecomment-424933944, or mute the thread https://github.com/notifications/unsubscribe-auth/ADAQrDA3cq-gycim4e34O5SJyVghAYIvks5ufDSvgaJpZM4W7HiI .

Georacer commented 5 years ago

I like the new API. I disabled hidden files by default and toggling them with ctrl+space is straightforward.