marvinkreis / rofi-file-browser-extended

Use rofi to quickly open files
MIT License
240 stars 15 forks source link

Space in folder name results in buggy behaviour #8

Closed Georacer closed 5 years ago

Georacer commented 5 years ago

I found another bug in file_browser today, sorry if I start looking pedantic. If navigating in a path containing a space, file opening behaviour is erratic.

Steps to reproduce:

  1. Create path and file:
    :~$ mkdir test\ folder
    :~$ cd test\ folder/
    :~/test folder$ touch test_file.txt
    :~/test folder$ echo "example content" >> test_file.txt 
    :~/test folder$ cat test_file.txt 
    example content
  2. Launch file_browser and select gedit to open files: rofi-2018-09-27-1956-00000
  3. Navigate to directory and select file: rofi-2018-09-27-1957-00000
  4. gedit opens two files and none of them is the correct one: screenshot from 2018-09-27 19-57-30
marvinkreis commented 5 years ago

Yeah, I noticed that as well while fixing the other stuff. I have a fix for this already, I'll push it soon.

Don't worry about opening too many issues, I appreciate the feedback.

Georacer commented 5 years ago

Tested and working fine!