Closed Shaggy84675 closed 2 years ago
Would you have some screenshots before/after to show the benefits of your MR ?
Oh sure. It's basically something what embeds already supports, it was just missing there. There's a picture where you can see first embed without using the timestamp function and the rest of it with the function. You can set whatever time you want there but I'm not really sure if it's good for log messages (because of the format), so that's the reason why I didn't suggested to move the timestamp from title into embed timestamp and add it more like an optional function for people who would like to use it in custom converters.
All good. Thanks, 1.3.0 released.
I've added a new method into embeds so timestamp can be shown in the footer.
During tests I've also noticed there's an error in test: "includes_stacktrace_in_content_when_attachment_disabled", but I can't find why. This error has nothing common with the timestamp implementation and it was there before.
If there's anything I should do more or fix, let me know.