search

marvinscham / disenchanter

A tool to mass disenchant champion shards and other League of Legends loot.
MIT License
109 stars 9 forks source link

Disenchant (duplicate) Permanents #12

Closed marvinscham closed 2 years ago

marvinscham commented 2 years ago

Is your feature request related to a problem? Please describe. You can already disenchant shards but not yet permanents. Some things like Honor 5 Capsules drop permanents that might not be needed.

The same applies to (checked is implemented)

This probably does not apply to summoner icons and emotes as they AFAIK only come as permanents.

Describe the solution you'd like If permanents are owned, ask whether to disenchant them before asking about keeping those you don't own yet.

Additional context Prefer keeping shards over permanents to maximize disenchant value.

marvinscham commented 2 years ago

lootId might be like CHAMPION_1, needs tests for both disenchanting and mastery upgrading.

marvinscham commented 2 years ago

Tactician support for permanents is not yet included as data on those is missing, debt of implementation is moved to #19 as handling permanents will be considered a given from now on.