search

marvinscham / disenchanter

A tool to mass disenchant champion shards and other League of Legends loot.
MIT License
109 stars 9 forks source link

Traditional Chinese translation #132

Closed nico12313 closed 1 year ago

nico12313 commented 1 year ago

I have translated your beautiful work into Traditional Chinese for Taiwan people, already build and run the exe file to make sure everything work. if there is anything you think inappropriate in this branch please let me know, thank's for your hard work on this project!

marvinscham commented 1 year ago

Thank you for putting in the work! Unfortunately, I can't merge this Pull Request as it would overwrite the original English version. Instead, I'd like to feature your translated repository in the project's README so users searching for a version of the app in Traditional Chinese can find it in your forked repository.

If you agree with that, would you mind to translate this for me to put into the README file?:

A version of the app in Traditional Chinese is available here.

nico12313 commented 1 year ago

Thank you for putting in the work! Unfortunately, I can't merge this Pull Request as it would overwrite the original English version. Instead, I'd like to feature your translated repository in the project's README so users searching for a version of the app in Traditional Chinese can find it in your forked repository.

That's alright, it is also my concern and the reason why I ask for your opinion in pull request. Redirect to my repo will do just fine, I just try to make sure the author is comfortable about the way I'm giving credit.

If you agree with that, would you mind to translate this for me to put into the README file?:

more then happy to do!

A version of the app in Traditional Chinese is available here.

可以在這裡找到繁體中文版本的應用程式.

marvinscham commented 1 year ago

Great! I've added it to the README. Thanks again for making the tool accessible for more people. Closing the PR with this.