Cannot update/use disenchanter after V14.10 (2.0.0) update

supermarth64 commented 4 months ago

Screenshot Untitled

Description (if necessary)

Had LOL patch 14.10 installed
Had disenchanter v.1.8.0 installed, opened it up.
Prompted for an update, I said yes.
Update failed (didn't grab a screenshot here). Deleted both disenchanter.exe and disenchanter_up.exe.
Downloaded a fresh copy of v2.0.0 from Github. Tried to run it, gave attached error. It gave the same error when failing the update.

Version v2.0.0

marvinscham commented 4 months ago

@supermarth64 Thanks for taking the time to report! I've replaced the broken disenchanter.exe with a new one fixing this. You can download it from the v2.0.0 page once again.

marvinscham commented 4 months ago

Docs in case someone has a similar problem:

Error was:

./disenchanter.exe
<internal:C:/Users/User/AppData/Local/Temp/ocr43B0.tmp/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:136:in `require': cannot load such file -- C:/Ruby32-x64/lib/ruby/gems/3.2.0/gems/bundler-2.4.19/lib/bundler/
setup (LoadError)
        from <internal:C:/Users/User/AppData/Local/Temp/ocr43B0.tmp/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:136:in `require'

This happened because I used bundle exec ocran instead of just ocran to build the exe, which at some point seems to introduce an absolute reference to bundler's path on the build machine. This breaks the app unless you have bundler installed, which is why the error didn't occur when testing locally.

marvinscham / disenchanter

Cannot update/use disenchanter after V14.10 (2.0.0) update #187