search

marwanhawari / stew

🥘 An independent package manager for compiled binaries.
MIT License
193 stars 14 forks source link

Various updates #36

Closed abs3ntdev closed 7 months ago

abs3ntdev commented 7 months ago

Hello. I started using stew recently and wanted to update some things.

switched from AlecAivazis/survey to charmbracelet/huh updated urfave/cli to v3 and added completion scripts removed vendors directory and updated dependencies removed deprecated things(ioutils) uses archiver.fromextension instead of a hardcoded list of extensions to check if a file is an archive

I can split this up into a few PRs if it would be easier to manage. Let me know if there is anything in this PR you don't want merged and I can remove it as well.

I'd like to add custom repo support in the near future as well, mostly gitea and gitlab instances.

Thank you!

marwanhawari commented 7 months ago

Hey thank you so much for all of this! Yes, I would want all of these split into separate PRs before I can review.

switched from AlecAivazis/survey to charmbracelet/huh

This is awesome! Could you include before and after screenshots in your PR for this.

updated urfave/cli to v3 and added completion scripts

Not super familiar with completions, so when you open this PR could you describe what you did with some more detail and can you include some usage examples?

removed vendors directory and updated dependencies

Dependencies should be updated, but what's your reason for removing the vendor directory?

uses archiver.fromextension instead of a hardcoded list of extensions to check if a file is an archive

This is already covered by #28, so don't worry about opening another PR for this

I'd like to add custom repo support in the near future as well, mostly gitea and gitlab instances.

Whenever you're ready, you should open an issue for this. I'd be interested to read your proposal.

abs3ntdev commented 7 months ago

I will split it up into a few PRs tonight.

Dependencies should be updated, but what's your reason for removing the vendor directory?

with modules existing im not sure the purpose of maintaining a vendors directory for a project like this. i can not delete them if you are against removing them.

Not super familiar with completions, so when you open this PR could you describe what you did with some more detail and can you include some usage examples?

will do. its just the tab completions scripts from https://github.com/urfave/cli/tree/main/autocomplete with minor modifications