search

marxin / cvise

Super-parallel Python port of the C-Reduce
Other
219 stars 25 forks source link

remove-unused-outer-class is very restrictive on what it removes #112

Open aeubanks opened 1 year ago

aeubanks commented 1 year ago

remove-unused-outer-class seems very restrictive on when it'll consider a class for removal. It won't consider classes with templates or a base class.

There are many times where the code doesn't compile if you remove a template param or a base class and doesn't pass the interestingness test, but the class isn't referenced otherwise and is fine to completely remove.

Any thoughts?

marxin commented 1 year ago

Sure, please create a pull request where you would relax the restrictions and add new test-cases for the situations you are interested in.

Thanks.