search

marxin / cvise

Super-parallel Python port of the C-Reduce
Other
219 stars 25 forks source link

Add clang version string to clang_delta --version #122

Closed mortior closed 8 months ago

mortior commented 8 months ago

This adds the version of clang currently in use to the output from clang_delta --version and changes the test script to use this information instead of looking at the list of dynamic libraries when checking which clang version is in use. This allows the tests to run when clang_delta is statically linked against libClang.

marxin commented 8 months ago

Sure, I like the suggested approach and thank you for the contribution.

About the Ubuntu failing CI, we've got the following output:

root@a9adb237d902:/cvise/build# ./clang_delta/clang_delta --version
clang_delta 2.9.0
Git version: 3fbf977
Ubuntu clang version 18.0.0 (++20240102083407+5c458ed490a0-1~exp1~20240102083515.227)

Can you please fix it accordingly?

mortior commented 8 months ago

Sure, I like the suggested approach and thank you for the contribution.

About the Ubuntu failing CI, we've got the following output:

root@a9adb237d902:/cvise/build# ./clang_delta/clang_delta --version
clang_delta 2.9.0
Git version: 3fbf977
Ubuntu clang version 18.0.0 (++20240102083407+5c458ed490a0-1~exp1~20240102083515.227)

Can you please fix it accordingly?

I made clang_delta remove the prefix. To me it is completely uninteresting that the clang libraries was compiled for ubuntu. I hope you find this an ok solution.

marxin commented 8 months ago

Yep. Thank you for your contribution.