marxin / cvise

Super-parallel Python port of the C-Reduce
Other
242 stars 25 forks source link

Discourage -Werror in README.md #66

Closed avikivity closed 2 years ago

avikivity commented 2 years ago

-Werror makes some passes ineffective as the introduce warnings, and -Werror turns those into errors.

marxin commented 2 years ago

Thanks for your pull request. However, I would rather make -Werror working also for Release configurations.

avikivity commented 2 years ago

There's a misunderstanding. I'd like to discourage -Werror for the interestingness test, not for cvise itself. I like -Werror myself (which was why I was bitten by it when I left it in the interestingness test).

marxin commented 2 years ago

Ohh! I'm really sorry :) Sure, I like your pull request.