marxin / cvise

Super-parallel Python port of the C-Reduce
Other
219 stars 25 forks source link

Improved merge-base-class transformation #98

Closed strimo378 closed 1 year ago

strimo378 commented 1 year ago
  1. The transformation learned to merge templated base classes
  2. The transformation was splitted into two transformation: (1) remove-base-class only removes the base class, (2) merge-base-class removes the base class and copies the content of the base class
marxin commented 1 year ago

Please fix the issue with older LLVM, and please add a comment to getDescribedTemplateParams mentioning which LLVM version needs the function.

strimo378 commented 1 year ago

I have no idea when getDescribedTemplateParams was introduced. Do you have an idea how to find out?

strimo378 commented 1 year ago

Can we deactivate the test case for clang9?

marxin commented 1 year ago

Do you have an idea how to find out?

git branch --all --contains 2a3b86c157166f3b15f718443334ab0e27b40592 | grep release
  remotes/origin/release/11.x
  remotes/origin/release/12
  remotes/origin/release/12.x
  remotes/origin/release/13.x
  remotes/origin/release/14.x
  remotes/origin/release/15.x

So it's there likely since 11.x. So please document that it's not needed since LLVM 11. For now, I would like to keep support for LLVM 9 as openSUSE Leap uses it.

marxin commented 1 year ago

Can we deactivate the test case for clang9?

Yes, please take a look at e5c9c380d1fc05bb2e11003b7d135897ce824da8.

marxin commented 1 year ago

Please rebase on top of 48a8e24bfda0192084505e0ba2cebfab3e65f7a6, I fixed there LLVM version detection.

strimo378 commented 1 year ago

So ... rebased ... are 3 commits ok, or should I combine them?

marxin commented 1 year ago

Please squash them into one.

marxin commented 1 year ago

Next time, please use "Convert to draft" instead of renaming ;)

strimo378 commented 1 year ago

Thx for the hint. It took me 5 min to find it on the page :)

marxin commented 1 year ago

It took me 5 min to find it on the page :)

Yeah, it's a pretty small button.