search

marxjohnson / btsyncindicator

Bittorrent Sync indicator for linux desktops
GNU Lesser General Public License v3.0
41 stars 5 forks source link

Debian Packaging btsync-user: Location of bitmaps #2

Closed tuxpoldo closed 11 years ago

tuxpoldo commented 11 years ago

btsyncindicator.py searches by default its bitmap files in subdirectory located below btsyncindicator.py itself. Currently the Debian package installs btsyncindicator.py in /usr/lib/btsync-user and the bitmaps in /usr/lib/btsync-user/icons but this does not conforms to the Debian policy - in fact lintian complains:

W: btsync-user: image-file-in-usr-lib usr/lib/btsync-user/icons/btsync-active.png W: btsync-user: image-file-in-usr-lib usr/lib/btsync-user/icons/btsync-attention.png W: btsync-user: image-file-in-usr-lib usr/lib/btsync-user/icons/btsync-error.png W: btsync-user: image-file-in-usr-lib usr/lib/btsync-user/icons/btsync.png

Solution approach 1 (preferred): Allow the user to override the bitmap subdirectory with a command line parameter

Solution approach 2: On startup, test if there are bitmap files in the icons/-subsdirectory. If not, use the subdirectory /usr/share/btsync-user/icons

marxjohnson commented 11 years ago

Ok, solution 1 sounds sensible. I can have it default to ./icons with a parameter to override it to /user/share/btsync-user/icons.

tuxpoldo commented 11 years ago

Obviously it should be better if you can specify a parameter on the command line. e.G.:

btsyncindicator.py --iconpath=/home/leo/myicons

or

btsyncindicator.py -I /home/leo/myicons

marxjohnson commented 11 years ago

Closed by 5c0e5731483f6ad0d90a5543c0c0527d3dba9405, there is now a --iconpath parameter which defaults to ./icons