search

marxjohnson / btsyncindicator

Bittorrent Sync indicator for linux desktops
GNU Lesser General Public License v3.0
41 stars 5 forks source link

AppIndicators and GTK Tray Compatability #42

Open ghost opened 10 years ago

ghost commented 10 years ago

Hey Mark, I just merged your app indicator code into mine, please test this out and maybe merge??

I think some work still needs to be done in the following areas

  1. Where will btsync store its standard config file?
  2. Should we break out the gtk tray stuff into a separate .py and have it get imported?
  3. I change the class name and some documentation stuff, So just a heads up if you do merge it.
  4. Had to remove OS specific package detection, it broke things on my Gentoo system

Right now it tries for appindicator and if that fails uses gtk tray as a fall-back...

marxjohnson commented 10 years ago

Hi @Teknocrat I've had to merge your changes in manually, but I think I've managed to get a reasonably elegant and python-style solution in place. However, as I'm on Ubuntu, I can't check that it works! Can you grab the modified indicator script from my gtktrayicon branch and test it out for me?

ghost commented 10 years ago

Hey sorry for the delay been swamped I'm gonna get to this tonight or tomorrow for sure

On February 22, 2014 10:49:47 AM EST, Mark Johnson notifications@github.com wrote:

Hi @Teknocrat I've had to merge your changes in manually, but I think I've managed to get a reasonably elegant and python-style solution in place. However, as I'm on Ubuntu, I can't check that it works! Can you grab the modified indicator script from my gtktrayicon branch and test it out for me?

Reply to this email directly or view it on GitHub: https://github.com/marxjohnson/btsyncindicator/pull/42#issuecomment-35805672