search

marxjohnson / btsyncindicator

Bittorrent Sync indicator for linux desktops
GNU Lesser General Public License v3.0
41 stars 5 forks source link

Icon Size? #8

Closed tuxpoldo closed 11 years ago

tuxpoldo commented 11 years ago

In Ubuntu it seems that the default icon size for indicators is 22x22 - btsync-user packaging installs the icons there, but lintian complains about the wrong size.

What should we do? Create a dedicated directory or adapt the icon size?

W: btsync-user: icon-size-and-directory-name-mismatch usr/share/icons/hicolor/22x22/status/btsync-active.png 17x19
W: btsync-user: icon-size-and-directory-name-mismatch usr/share/icons/hicolor/22x22/status/btsync-attention.png 17x19
W: btsync-user: icon-size-and-directory-name-mismatch usr/share/icons/hicolor/22x22/status/btsync-error.png 17x19
W: btsync-user: icon-size-and-directory-name-mismatch usr/share/icons/hicolor/22x22/status/btsync.png 17x19
marxjohnson commented 11 years ago

Fix the icon size. #7 has updated icons, but they're not 22x22. I'll ask beadricus if he can change that before I merge.

tuxpoldo commented 11 years ago

I'm not sure, if the icons must be 22x22. In /usr/share/icons/hicolor/22x22/status there are several status indicator icons and so I decided to install them here. For me it is also OK to create a /usr/share/icons/hicolor/17x19/status directory ;-)

BTW: Since in this directory every icon has the name APPLICATION-STATUS.EXT, it would be a good idea to rename btsync.png to btsync-idle.png

beardicus commented 11 years ago

Now fixed in #7. Regarding filenames for the default icon: many of my indicator icons seem to reside in /apps, not /status, and seem to be named just "dropbox.png" or "zim.png". Easy fix either way though...

marxjohnson commented 11 years ago

This issue is fixed by #7 as @beardicus says. @Tuxpoldo, if the icon filename is going to be an problem, please open a new issue for it.