search

marxjohnson / moodle-block_quickfindlist

Moodle block providing a quick method of searching users
http://moodle.org/mod/data/view.php?d=13&rid=2200
6 stars 15 forks source link

Upgrading of QuickFind list #17

Closed atlet closed 8 years ago

atlet commented 8 years ago

Hi, I did some modifications (upgrades) to plugin. Can you please review and take it if you think that also other users will benefit from them.

Changes, I did:

Regards Andraž

sensei-hacker commented 8 years ago

Thanks for that. Why does it now require a much newer version of Moodle?

The code should use $DB->sql_like(...) or $DB->sql_like_escape(...).

On Thu, Jul 14, 2016 at 1:45 AM, Andraž notifications@github.com wrote:

Hi, I did some modifications (upgrades) to plugin. Can you please review and take it if you think that also other users will benefit from them.

Changes, I did:

  • Changed minimum Moodle version to 2.9.
  • Added option to search by username and name and surname mixed.

Regards Andraž

You can view, comment on, or merge this pull request online at:

https://github.com/marxjohnson/moodle-block_quickfindlist/pull/17 Commit Summary

  • Changed minimum Moodle version to 2.9.
  • Added option to search by username and name and surname mixed.

File Changes

Patch Links:

- https://github.com/marxjohnson/moodle-block_quickfindlist/pull/17.patch

https://github.com/marxjohnson/moodle-block_quickfindlist/pull/17.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/marxjohnson/moodle-block_quickfindlist/pull/17, or mute the thread https://github.com/notifications/unsubscribe/AB4UVJxMKmeaPsJiVrLuAFFmT1Osu2oWks5qVdrsgaJpZM4JMIVn .

atlet commented 8 years ago

Tnx for your comment. I converted to $DB->sql_like(...).

Why does it now require a much newer version of Moodle? Because of this error: Fatal error: Call to undefined method page_requirements_manager::js_call_amd() in /home1/uaeac/public_html/ADSM/LMSClone/blocks/quickfindlist/block_quickfindlist.php on line 197

js_call_amd -> this is implemented in Moodle 2.9+