search

marxjohnson / moodle-block_quickfindlist

Moodle block providing a quick method of searching users
http://moodle.org/mod/data/view.php?d=13&rid=2200
6 stars 15 forks source link

"PHP Notice: pix_url is deprecated. Use image_url for images and pix_icon for icons." #21

Closed NMCPaul closed 6 years ago

NMCPaul commented 6 years ago

Getting a lot of these errors in my error log. A quick replacement of pix_url with image_url on line 126 of block_quickfindlist.php fixed it.

sensei-hacker commented 6 years ago

@NMCPaul

I don't have a site to test on at the moment. Can you please look carefully at this pull request #22 and tell me if it looks right?:

PR https://github.com/marxjohnson/moodle-block_quickfindlist/pull/22

NMCPaul commented 6 years ago

It looks good to me. That’s literally all I did and it took care of the PHP warnings.

Also, the same thing happens on your quickcourselist plug-in (which we also use). The exact same fix took care of the warnings as well.

On Tue, Aug 28, 2018 at 8:53 PM Ray Morris notifications@github.com wrote:

@NMCPaul https://github.com/NMCPaul

I don't have a site to test on at the moment. Can you please look carefully at this and tell me if it looks right?:

22 https://github.com/marxjohnson/moodle-block_quickfindlist/pull/22

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/marxjohnson/moodle-block_quickfindlist/issues/21#issuecomment-416787404, or mute the thread https://github.com/notifications/unsubscribe-auth/ABXQ76IyniwEkehvwMSstHgMbCjqnlxaks5uVeYkgaJpZM4WQFAU .

--

Paul Martin Network Systems and Data Communications Analyst (231) 995-1959 | Northwestern Michigan College

sensei-hacker commented 6 years ago

Thanks @NMCPaul I merged that change here.

I submitted PR https://github.com/marxjohnson/moodle-block_quickcourselist/pull/12 for quickcourselist

We'll need @marxjohnson to approve it because I don't have we're access to that repo