search

marysaka / nx-dreport

A custom Nintendo Switch sysmodule (KIP) to automatically delete erpt save during boot
GNU General Public License v2.0
40 stars 4 forks source link

3.0.1 issue ? #4

Open ShinKaz opened 6 years ago

ShinKaz commented 6 years ago

Hi, I tried clearing the logs with nx-dreport on 3.0.1 but my error on horizon is still there. (my ini path is right too)

not sure what's going one here.

(I don't have the time to read the text either, before it boots to Horizon, sadly)

DavidBuchanan314 commented 6 years ago

Try compiling with DEBUG defined. I think you'll find that fsprInitialize() fails. I think this is because there can only be one connection to this service at once, but the latest atmosphere sm(?) version has an option to override that iirc. Edit: this - https://github.com/Atmosphere-NX/Atmosphere/commit/ec78fa5977778516e191b64ada550b071e6a044b

@Thog I'm not sure I agree with your decision to exit without error, by default.

marysaka commented 6 years ago

I don't have any console with 3.x anymore so that will be hard for me to test that. As said by @DavidBuchanan314 try to compile with DEBUG defined.

@DavidBuchanan314 The thing is that I don't want to create error reports for the end user that may be uploaded... maybe I should try to make it panics even if it's not user friendly?

DavidBuchanan314 commented 6 years ago

Well, if there's an error running nx-dreport, then the logs have not been deleted anyway - adding an extra error isn't going to hurt much. And now the user is a aware that there is a problem that needs to be fixed.

If there's a problem, and there is no error, then the user will continue on regardless, assuming that their logs have been wiped, which is of course a dangerous situation.

I guess the optimal solution would be to have a custom panic screen, which would generate no logs. But maybe that's more effort than it's worth...

CTCaer commented 6 years ago

Hmmm, is it too early in the initialization to speak to audio/gfx/hid service?

Maybe a tone or custom pop up with a message or rumble patterns can do the job. Whatever gets loaded before nx-dreport

ShinKaz commented 6 years ago

why not just display the error for 5sec ? or a key prompt ?

sadly I don't have the environnement to compile it, I'm very sorry about that :(