search

marytts / gradle-marytts-voicebuilding-plugin

A replacement for the legacy VoiceImportTools in MaryTTS
http://mary.dfki.de/
GNU General Public License v3.0
16 stars 12 forks source link

some durations == -1 #133

Open seblemaguer opened 4 years ago

seblemaguer commented 4 years ago

In the task f0ContourFeatureFileMaker, at this line:

https://github.com/marytts/gradle-marytts-voicebuilding-plugin/blob/9f641d56ed1c2016f72b972aec8ca18ad87e851d/src/main/groovy/de/dfki/mary/voicebuilding/tasks/F0ContourFeatureFileMaker.groovy#L273

the duration of the unit == -1 which leads to fails the following assert

seblemaguer commented 4 years ago

@psibre is there a reason for this:

https://github.com/marytts/gradle-marytts-voicebuilding-plugin/blob/9f641d56ed1c2016f72b972aec8ca18ad87e851d/src/main/groovy/de/dfki/mary/voicebuilding/tasks/PhoneUnitFileMaker.groovy#L57-L59

????

psibre commented 4 years ago

This is taken from

https://github.com/marytts/marytts/blob/c0df394604169fe520efd1d95d9b627309d9032f/marytts-builder/src/main/java/marytts/tools/voiceimport/PhoneUnitfileWriter.java#L150-L153

The Timeline format marks the boundary units as having duration -1; IIRC there are even some parts in the code where this antipattern is used to check if a unit is a boundary. =(