search

marytts / marytts-lang-hsb

Upper Sorbian language component for MaryTTS
GNU Lesser General Public License v3.0
2 stars 2 forks source link

Add tests for number expansion #2

Closed psibre closed 3 years ago

psibre commented 3 years ago

We need to verify that numeric tokens are pronounced correctly.

psibre commented 3 years ago

@JMK-CB Could you please provide a handful of more complicated examples we can include as test cases in #4?

JMK-CB commented 3 years ago

I have created a list that should cover all or most possibilities regarding cardinal numbers for Upper Sorbian.

Testzahlen HSB.zip

BTW: uploading CVS was not supported, hence the ZIP.

psibre commented 3 years ago

@JMK-CB Thanks very much -- that's perfect!

But to expand the number expansion capabilities, we need to get more sophisticated format rules than the stub we currently have... Could you please share the extended formatRules.txt you have created (CC @aStereoID)? Thanks!

aStereoID commented 3 years ago

Friday's list:

formatRules.txt

psibre commented 3 years ago

@aStereoID Perfect, thanks!

psibre commented 3 years ago

@JMK-CB @aStereoID Thanks very much for your help!

I think we need to follow up on this to get more flexibility, especially regarding real numbers (in addition to natural numbers), ordinals (in addition to cardinals), and special numbers such as years. We should do that in a new issue.