marytts / voice-cmu-slt

Other
2 stars 5 forks source link

The way this project runs Praat no longer works #4

Open peteroupc opened 7 years ago

peteroupc commented 7 years ago

The task legacyPraatPitchmarker runs Praat as follows:

praat /[...]/build/temp/script.praat /[...]/build/basenames.lst /[...]/build/wav/ /[...]/build/pm/ 100 500

Apparently, recent versions of Praat now treat each argument as individual scripts and not the command line as one script with several arguments. This causes errors such as basenames.lst not being a script, thus halting the build.

psibre commented 7 years ago

This has been a nuisance ever since Praat 6 was released. Please see marytts/marytts#540 for a related discussion.

There is some logic in the corresponding task action to determine the praat exec syntax, but this can fail under some unusual cases, such as when the test process takes longer than expected to complete.

Maybe at this point, we should just assume that users will have praat 6+ installed, and allow explicit configuration to override it otherwise.