maryvilledev / codesplainUI

Web app for breaking down and annotating Python 3 source code.
https://www.codesplain.io
GNU General Public License v3.0
2 stars 2 forks source link

Don't show ignored rules in filters list #463

Closed Hopding closed 7 years ago

Hopding commented 7 years ago

Description

This PR prevents ignored filters from being displayed when a new set of mappings is being loaded. This will prevent 'Atoms' from being displayed as a filter (for now anyways - it is a persistent beast, and may show up again. Be wary...).

I also removed the call to window.location when a snippet is loaded via a user's snippet list. This way we do not have to reload the whole app and make unnecessary AJAX calls, resulting in a faster snippet loading experience.

Motivation and Context

Fixes #461. Prior to this change, when a snippet was loaded that required a new set of mappings to be loaded, the removeDeprecatedFilters function would fail to work properly, as the ignoredRules would not yet have been set.

Checklist: