maryvilledev / codesplainUI

Web app for breaking down and annotating Python 3 source code.
https://www.codesplain.io
GNU General Public License v3.0
2 stars 2 forks source link

Fix responsiveness of the RuleLabel buttons #525

Closed solkaz closed 7 years ago

solkaz commented 7 years ago

Description

Refactors the RuleLabel buttons to use flex-box properties, making them more responsive Also removes the padding from the Filter and Annotation titles, so there's more room for the content in their respective sections

Motivation and Context

Fixes #517

Checklist:

Browsers

Screenshots (if appropriate):

Hopding commented 7 years ago

This is definitely a nice improvement. However you removed the padding between the filters. Was that intentional? I'd prefer to keep it.

thebho commented 7 years ago

It was a compromise to use dynamic sizing

Hopding commented 7 years ago

Why is padding incompatible with resizing?

solkaz commented 7 years ago

*Margin, not padding. For some reason, adding margins breaks flexbox properties.

thebho commented 7 years ago

Yeah, this was the best of the options i saw. There is a slack history from yesterday if you are interested