Add option to change Codemirror styles

maryvilledev / codesplainUI

Web app for breaking down and annotating Python 3 source code.

https://www.codesplain.io

GNU General Public License v3.0

2 stars 2 forks source link

Add option to change Codemirror styles #538

Closed solkaz closed 7 years ago

solkaz commented 7 years ago

Description

What the title says. Your selected theme will be saved in cookies, so if you select the monokai theme and then exit Codesplain, you can expect the theme to be selected when you return

Motivation and Context

Fixes #468

Checklist:

[x] My code follows the code style of this project.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Browsers

[x] Chrome
[x] Firefox
[x] Safari
[ ] Mobile:
[ ] Other:

thebho commented 7 years ago

Does this just add the color palette icon or add the settings menu we discussed?

solkaz commented 7 years ago

It still has the gear icon that only handles the theme.

solkaz commented 7 years ago

@thebho fixed

thebho commented 7 years ago

Looks like it doesn't have a tool tip either. Maybe something like Change Editor Theme or CodeMirror Styles

solkaz commented 7 years ago

It makes more sense to me to just have one IconMenu at this point, if the app has this many actions + tooltips for each of them.

thebho commented 7 years ago

I'm not sure we can even put this through right now. The benefit doesn't outweigh the problems it adds

solkaz commented 7 years ago

It only adds problems for the "users" if they want highlighting with a dark theme. Light themes seem to be fine, and this is also a first iteration for this functionality that we can improve on. Those who want dark themes can choose to not use highlighting or use a different theme for highlighting, or accept that for now, it's not perfect, and we might or might not fix it.

dane-johnson commented 7 years ago

No reason it can't be good the first time.