search

maryvilledev / skilldirectoryui

React front-end for the Skill Directory API
0 stars 0 forks source link

Display link_type as icon #142

Closed thebho closed 7 years ago

thebho commented 7 years ago

Instead of Webpage: Java Home, it should be: {icon} Java Home

thebho commented 7 years ago

I like these options: https://material.io/icons/

Suggestions: Home (for Webpage/Home page) Library Books (for Tutorial) Computer (for Blog)

Hopding commented 7 years ago

I like the idea of adding icons, but I do not think that we should remove the text too. I don't think the icons are clear enough to somebody who does not already know what they mean (everybody not on the co-op team). So, I would suggest {icon} Webpage: Java Home

thebho commented 7 years ago

How about hover displays the type?

Hopding commented 7 years ago

Hovering for the type might work.

In addition to adding icons, it may also be useful to separate them into sections. So instead of:

Webpage: xxx
Webpage: xxx
Webpage: xxx
Blog: xxx
Blog: xxx
Blog: xxx
...

... we should have

Webpage:
   xxx
   xxx
   xxx
Blog:
   xxx
   xxx
   xxx
...
thebho commented 7 years ago

Yeah, that's a good option. I'd be curious how they each look mocked up