Plugin installation fails if default path is inaccessible

marzent / IINACT

A Dalamud plugin to run the FFXIV_ACT_Plugin in an ACT-like enviroment with a heavily modified port of Overlay Plugin

https://www.iinact.com

GNU General Public License v3.0

194 stars 43 forks source link

Plugin installation fails if default path is inaccessible #108

Open PixelHir opened 3 months ago

PixelHir commented 3 months ago

Not sure if I have some unusual home directory permissions but IINACT was unable to create an IINACT folder in my documents folder. I created it manually and it worked however it feels a bit unusual for plugin to instantly fail like that - especially if a user could wish to instantly change their IINACT directory on start. Maybe it would be better if user could be still able to install plugin even if IINACT can't access the folder - and inform them appropriately to grant permission or change destination folder?

marzent commented 3 months ago

This is unfortunately not really feasible, since the FFXIV_ACT_Plugin needs to be initialized together with IINACT and at the point in time it is not possible to show a popup or folder selection dialog (at least not without rewriting basically the entire plugin startup sequence)... But I am wondering, are you running some kind of AV that blocks certain actions in the Documents folder? If so an exclusion for Dalamud and all its plugins would probably also work here.

PixelHir commented 3 months ago

I only have the installed by default windows defender - I have completely no idea why the access was denied as I remember it used to work, maybe that’s some new 24H2 quirk…

PixelHir commented 3 months ago

Oh never mind, it’s not about the permission, I copied plugin configs from my old windows install and the user folder has changed - so that one doesn’t exist. My bad, needed to take a look at the log one more time. Although I have created the new folder in new user folder and it worked after that so I’m not sure if some fallback triggered or something…