search

marzent / IINACT

A Dalamud plugin to run the FFXIV_ACT_Plugin in an ACT-like enviroment with a heavily modified port of Overlay Plugin
https://www.iinact.com
GNU General Public License v3.0
182 stars 41 forks source link

Manually ending/resetting encounters #19

Closed maributt closed 1 year ago

maributt commented 1 year ago

I was wondering if a feature like ACT's "/e end" command (or just a way to generally manually reset/end a fight) would ever be added to the project? Personally it's only last thing I'm missing from it, awesome work!

marzent commented 1 year ago

Will take try to implement this feature, I wonder which component is responsible for ending the combat usually with that text command

SMNIRL commented 1 year ago

I'm not sure about that command specifically, but OverlayPlugin has a routine for automatically ending encounters on wipe. Could look there as well.

marzent commented 1 year ago

Ah yes I know what OP does and the method it calls in NotACT (which is currently implemented)

I am just wondering if the ffxiv act plugin is not working correctly here or whether this is a functionality in base ACT which still needs to be imitated

SMNIRL commented 1 year ago

This comment on the ACT forums leads me to believe it's part of base ACT https://forums.advancedcombattracker.com/discussion/224/hotkey-for-end-encounter

marzent commented 1 year ago

Did a bit of a static analysis of how that is supposed to be working and it looks like it should already be fine, will take a look again once the ffxiv parsing plugin has been updated

marzent commented 1 year ago

Fixed with https://github.com/marzent/IINACT/commit/3e52213f4199152ef4fdc4b05a9b86f2100c06c0

You can now end an encounter with /endenc