search

marzent / IINACT

A Dalamud plugin to run the FFXIV_ACT_Plugin in an ACT-like enviroment with a heavily modified port of Overlay Plugin
https://www.iinact.com
GNU General Public License v3.0
182 stars 41 forks source link

Fix Cactbot filenames in presets #22

Closed Sharparam closed 1 year ago

Sharparam commented 1 year ago

All of them are lowercase, see https://github.com/quisquous/cactbot/tree/main/ui for reference.

(Should all of them be lowercased by default instead, like what is done for dirName?)

As a sidenote, using Path.Combine to construct the URLs doesn't seem right, since that will result in backslashes on Windows rather than forward slashes.

I figure I'll also just shamelessly ask: Could you consider adding the hacktoberfest-accepted label to this PR if it's merged? :)

marzent commented 1 year ago

There you go :)

marzent commented 1 year ago

Considering the functional improvements these would probably be wasted effort, since ultimately the plan was to move to a http reserve proxy (for better browser compatibility) and redo the URL with that