search

marzent / IINACT

A Dalamud plugin to run the FFXIV_ACT_Plugin in an ACT-like enviroment with a heavily modified port of Overlay Plugin
https://www.iinact.com
GNU General Public License v3.0
182 stars 41 forks source link

About type #39

Closed tssailzz8 closed 1 year ago

tssailzz8 commented 1 year ago

i think we can use attribute rather than use that method

marzent commented 1 year ago

Indeed this is much faster and we don't need to use reflection here...

Would you mind changing GetPartyType itself, since it is being used multiple times?

tssailzz8 commented 1 year ago

in face,i want to use dalamud data

marzent commented 1 year ago

Indeed that would be nice long term

marzent commented 1 year ago

Thanks for this; I have implemented this fix in GetPartyType already with https://github.com/marzent/IINACT/commit/79a26cdd4c73aad7f4e051786d15bc7ef17ecdc5 so will be closing this