search

marzent / IINACT

A Dalamud plugin to run the FFXIV_ACT_Plugin in an ACT-like enviroment with a heavily modified port of Overlay Plugin
https://www.iinact.com
GNU General Public License v3.0
182 stars 42 forks source link

Change data exposed over IPC to type other than Newtonsoft JObject #98

Open lichie567 opened 1 month ago

lichie567 commented 1 month ago

Currently the json being exposed to other plugins via IPC is exposed as a JObject type from the newtonsoft library, which blocks (or significantly hinders) use of any other json parsing library in plugins consuming the data.

marzent commented 1 month ago

Which datatype do you think would make more sense?

marzent commented 1 month ago

Just to add a bit more context, OverlayPlugin uses heavily Newtonsoft and I try very hard to maintain source compatibility with them as much as possible... So in any case the data that is generated will be a newtonsoft JObject and passing that around is the most efficient approach (this works doubly well since Dalamud provides the newtonsoft reference and I heard there are basically no plans to move from it away in the near future). But am open to changing the API surface here if it is too inconvenient, since LMeter is the only consumer here I know of anyways.