marzent / wine-msync

A Mach semaphore-based synchronization mechanism for Wine on macOS. Built for speed, inspired by fsync.
GNU Lesser General Public License v2.1
85 stars 1 forks source link

Diablo IV (battle.net) crashes/doesn't launch with msync #5

Closed MysticalOS closed 10 months ago

MysticalOS commented 10 months ago

I've seen some say on wine 7.x using whisky it works but on wine 8.x with crossover (both 23.6 patched with cxpatcher) or 23.7 beta without patching and built in msync. if it's enabled it doesn't open. It's a shame cause esync causes massive gains vs no sync a tall, i imagine if msync worked it'd be even bigger gains.

I don't know how to log but if you tell me I'm happy to get some

marzent commented 10 months ago

Diablo 4 is a really special snowflake with the order of events (you will see WineD3D will work with all 3 sync mechanisms, albeit a bit slower, and for D3DMetal only esync works).

This isn't too bad though as the fix is a very tiny optimization which can lead to a bit more predictable results as you would expect from Windows.

If you are wondering the cx 23 patchset is empty now apart from that fix, since it will apply on top of the source of 23.7 after release. It is unlikely that https://github.com/marzent/wine-msync/commit/e3a8bb1cb3613e9305cd120c51bbb241d758e2af will make it for the public 23.7 version though, since we are already at rc1 (but I will still try to make it happen).

Also thanks for offering the logs, but was able to get that game as part of work now :)

MysticalOS commented 10 months ago

Yeah I'd love to see it make it in 23.7 but I know with, RC1 it's nearly closed and CW is pretty strict about merging in outside changes, heck i still think they're on D3DMetal 0.4, since I never saw release note they even merged in 1.0 and we're now at 1.1.

marzent commented 10 months ago

Ah 23.7 will ship GPTK 1.1 (and is pretty up-to-date in general), but yeah not sure there can be done much more atm.

MysticalOS commented 10 months ago

Ah it just didn't make it into notes. I been watching and since it's not in notes unsure and adding it in myself :D That should be noted

Gcenx commented 10 months ago

@marzent if that doesn’t get merged I’ll pull that MR into my CXPatcher branch.

MysticalOS commented 10 months ago

@marzent I'm sure answer is no but figured I'll ask. did you get them to ,erge change in 23.7 release today? if not, I'll test it when Dean here updates CxPatcher with it soon™

marzent commented 10 months ago

Yeah unfortunately not, will be in cx24 though

MysticalOS commented 10 months ago

Yeah meredith was talking about that in early 2024 in discord, guess we're done with 23.x now. :D

MysticalOS commented 10 months ago

Tested with 23.7+cxpatcher with your fix (since @Gcenx here pulled it in), still hangs at launch