marzer / tomlplusplus

Header-only TOML config file parser and serializer for C++17.
https://marzer.github.io/tomlplusplus/
MIT License
1.58k stars 152 forks source link

clang 10.0: error: unknown warning group '-Wsuggest-destructor-override' #145

Closed chronoxor closed 2 years ago

chronoxor commented 2 years ago
-- The C compiler identification is Clang [10](https://github.com/chronoxor/PrimeTrader/runs/5533378667?check_suite_focus=true#step:7:10).0.0
-- The CXX compiler identification is Clang 10.0.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/local/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/local/bin/c++ - skipped

/home/runner/work/PrimeTrader/PrimeTrader/modules/tomlplusplus/include/toml++/toml.h:16:1: error: unknown warning group '-Wsuggest-destructor-override', ignored [-Werror,-Wunknown-warning-option]
TOML_DISABLE_SPAM_WARNINGS;
^
/home/runner/work/PrimeTrader/PrimeTrader/modules/tomlplusplus/include/toml++/impl/preprocessor.h:85:3: note: expanded from macro 'TOML_DISABLE_SPAM_WARNINGS'
                TOML_DISABLE_SPAM_WARNINGS_CLANG_10; \
                ^
/home/runner/work/PrimeTrader/PrimeTrader/modules/tomlplusplus/include/toml++/impl/preprocessor.h:78:4: note: expanded from macro 'TOML_DISABLE_SPAM_WARNINGS_CLANG_10'
                        _Pragma("clang diagnostic ignored \"-Wsuggest-destructor-override\"") \
                        ^
<scratch space>:633:27: note: expanded from here
 clang diagnostic ignored "-Wsuggest-destructor-override"
                          ^
marzer commented 2 years ago

Thanks for the report + fix!