clang 10.0: error: unknown warning group '-Wsuggest-destructor-override' #145

marzer / tomlplusplus

Header-only TOML config file parser and serializer for C++17.

https://marzer.github.io/tomlplusplus/

MIT License

1.53k stars 146 forks source link

clang 10.0: error: unknown warning group '-Wsuggest-destructor-override' #145 #146

Closed chronoxor closed 2 years ago

chronoxor commented 2 years ago

[x] I've read CONTRIBUTING.md
[x] I've rebased my changes against the current HEAD of origin/master (if necessary)
[ ] I've added new test cases to verify my change
[ ] I've regenerated toml.hpp (how-to)
[ ] I've updated any affected documentation
[ ] I've rebuilt and run the tests with at least one of:
- [ ] Clang 6 or higher
- [ ] GCC 7 or higher
- [ ] MSVC 19.20 (Visual Studio 2019) or higher
[ ] I've added my name to the list of contributors in README.md

marzer commented 2 years ago

Hi, thanks for the contribution! Looks good to me, but before I can merge you'll need to also regenerate the single-header version of the library (see CONTRIBUTING.md for info).

chronoxor commented 2 years ago

Single header toml.hpp generated and provided!

chronoxor commented 2 years ago

Also I can confirm that now toml++ module compiles fine on all latest major platforms in github-actions:

chronoxor commented 2 years ago

Also provided a fix for MinGW platform

chronoxor commented 2 years ago

MinGW compiles fine as well

marzer commented 2 years ago

Thanks!