General Lag inside application with SP installed

inv0ke commented 7 years ago

Expected Behavior

Smooth sliding between screens (Chat, Camera, Stories etc), smooth photo/video taking and story viewing.

Current Behavior

When sliding across screens often the application lags and takens a few seconds to complete tasks, same for taking photos it takes a moment for the application to process the action and take the photo or video, also the same for selecting filters or emojis to overlay it will often take a long time to display the emojis or attach the filter and sometimes even crashes.

Possible Solution

Not sure, could be related to my setup since the phone with SP on it is fairly old.

Steps to Reproduce (for bugs)

General use of the application

Context

Makes using Snapchat with SnapPrefs enabled inconvenient because it often takes a long time to take a snap when it decides to lag, same for selecting emojis or filters. And makes reading chats/replying and browsing the screens (chat/camera/stories) slow and sometimes tedious.

Your Environment

Version used: SC 9.39.5.0 / Current stable build of SP
Android version: Galaxy S4 / Android 4.3
Xposed version and type (systemless or regular) Regular on 2.6.1
Root version and type (SuperSU, phh, etc. and system or systemless): SuperSU System via Towelroot (?)
Do you use any root/xposed hiding? If yes, which?: None

azsde commented 7 years ago

Same here on Galaxy S5 running CM 13 with systemless root and regular xposed version.

Andrerm124 commented 7 years ago

I mean, you are using an S4 - 4.3 so you can't really expect it to be buttery smooth. Other than that stock SC is noticeably slower than previous version (Nothing to do with SP), though you can try disabling Debug mode as I've heard some people have had some performance gains by doing that

inv0ke commented 7 years ago

@Andrerm124 Well I haven't had these problems on past stable versions of SP and this only happens with SP enabled/installed too like I said.

M1kep commented 7 years ago

As @andrerm124 said, disable debug and logging

vintheword commented 7 years ago

With the Instagram competition, snapchat has improved a lot on Android and has space to improve even more. The current snaprefs build has a LOT of functions/hooks/hacks and a few options worthless. This ends up causing xposed overhead, making things lag. I'm not saying that SP is poorly coded, but it got big and difficult to maintain everything it offers. My advice is avoid using any other module that modify a lot of stuff, like Wanam and Gravity Box and pray the next SC build has only the essencial to work.

valdeviant commented 7 years ago

I too am experiencing lag. I have disabled logging and debugging on build 92 with no luck. On TW 6.0.1, with only 2 modules running (this one and xinsta)

KennyTK commented 7 years ago

Also experiencing lag on Samsung S4 without any other overhead heavy applications running. SC without SP enabled runs super smooth. When enabling SP I mainly notice delay immediately after taking a picture (3-4 seconds of the image without any GUI).

Kebob commented 7 years ago

Just to note, I am still using Snapchat 9.21.1 on SnapPrefs 1.6.5 on a Nexus 6p Android 6.0 and have always had slight lag when using SnapPrefs. Considering the amount of hooking that is being done on Fragment and Activity loads it honestly was expected....It would be nice to have it smoother I guess but figured it's just a result of using an application that is hooking into almost every feature in an obfuscated app.

Once some of the larger bugs get worked out and the latest dev build becomes slightly more stable then I'm sure we can start making performance improvements or have the ability to enable only certain features so that the overhead can be reduced if you don't use everything. Then again - marz has been nice enough to make this module open source so you could always just manually remove what you don't need and rebuild.

marzika / Snapprefs