search

marzubov / ember-calendar

An awesome Ember calendar, designed with composability and reusability in mind.
MIT License
2 stars 5 forks source link

removes dependency on lodash #8

Closed jamesdixon closed 8 years ago

jamesdixon commented 8 years ago

This PR removes the dependency on lodash. The entire lodash library was being imported for the use of a single function (_.range). I went ahead and created a range utility function, which is literally the lodash function copied over. I could have used ember-browserify and imported the lodash.range npm module, but ultimately, that would have been bulky. In the interest of keeping things lean, I opted for this approach.

marzubov commented 8 years ago

Agree. Since we use only range - creating simple util is nice.