marzzzello / mpv_thumbnail_script

A Lua script to show preview thumbnails in mpv's OSC seekbar, sans external dependencies (fork)
GNU General Public License v3.0
278 stars 20 forks source link

Thumbnails are too small on HiDPI Screens #36

Open Oliver-Hanikel opened 1 year ago

Oliver-Hanikel commented 1 year ago

Problem

When using a 4k screen the thumbnails are too small. disney

Solution

The simplest possible solution would be to scale up the generated thumbnails by a constant factor, defined in the config file of the script. Maybe there is another simple and more flexible solution.

Alternative Solution

Setting the thumbnail_width or thumbnail_height to 600 did not result in bigger thumbnails (on a 1080p Video), but even if it did I don't really want to generate bigger thumbnails, because that could potentially take longer and fill up my /tmp directory. I would rather have small thumbnails that get scaled up (bilinearly?) to the desired size.

Thanks for maintaining the project :heart:

NicolaSmaniotto commented 1 year ago

It may be nice to scale the thumbnails based on how big the window is, the osc already does this somewhat.

po5 commented 1 year ago

The way thumbfast deals with this is by multiplying the configured thumbnail dimensions by display-hidpi-scale.

ftk commented 1 year ago

You might want to enable storyboard_upscale option. https://github.com/marzzzello/mpv_thumbnail_script/blob/6b42232c98ec699e79547b1f52b027d808e50d62/src/options.lua#L131

user18081972 commented 1 month ago

You might want to enable storyboard_upscale option.

https://github.com/marzzzello/mpv_thumbnail_script/blob/6b42232c98ec699e79547b1f52b027d808e50d62/src/options.lua#L131

Setting it to true or yes doesn't increase the size of the thumbnails

user18081972 commented 2 weeks ago

Problem

........... Setting the thumbnail_width or thumbnail_height to 600 did not result in bigger thumbnails (on a 1080p Video), but even if it did I don't really want to generate bigger thumbnails, because that could potentially take longer and fill up my /tmp directory. I would rather have small thumbnails that get scaled up (bilinearly?) to the desired size.

Thanks for maintaining the project ❤️

This might be a solution, it was for me anyway. See this issue: https://github.com/marzzzello/mpv_thumbnail_script/issues/69